Repository navigation
feat(aws-agents): update skills to reflect AgentCore CLI v1 - #522
Conversation
nborges-aws
changed the title
| payments = (target.get("resources") or {}).get("payments") | ||
| if not payments: | ||
| payments = data.get("payments") | ||
| if not payments: |
There was a problem hiding this comment.
Could we use agentcore status first when this is a v1 project? Migration keeps the old deployed-state.json, but v1 no longer updates its payments branch. If a manager or connector is replaced after migration, this path keeps returning the old IDs without ever checking status.
I reproduced this with a version-2 project and stale payment entries: it returned the old connector and made zero status calls. The updated setup_payment_user.py already does status-first discovery. It would be worth adding a regression test for this migrated-project case here too.
|
|
||
| ## Add Gateway targets | ||
|
|
||
| An action-group shim is a new Lambda backed Gateway target. Render the source action group into `tools/<shim>/handler.py` using the templates in this skill's `assets/`, with one `toolDefinitions` entry per source function or OpenAPI operation. Store the complete target object in a JSON file and add it through the CLI: |
There was a problem hiding this comment.
Could we keep the instruction to create a pyproject.toml alongside each rendered shim? The empty project and Harness scaffold don't create one in tools/<shim>, and the v1 CDK Python packager still requires it.
Following this guide with just handler.py fails with MissingProjectFileError: Required project file not found: .../tools/action-group/pyproject.toml. I reproduced that with the published @aws/agentcore-cdk@1.0.0 package. A minimal manifest example would help here; the mirrored guide under skills/core-skills needs the same instruction.
* feat(aws-agents): update skills to reflect AgentCore CLI v1 * fix(aws-agents): fix runtime and harness configuration guidance * fix(aws-agents): correct header allowlist example * fix(aws-agents): ensure agent deployment workflows persist selected target * fix(aws-agents): fix Privy guidance in payments skill * fix(aws-agents): persist selected target on gateway and policy operations * fix(aws-agents): fix payment admin setup instructions * fix(aws-agents): update agent auth and cross-session memory examples * fix: address review findings for agentcore CLI v1 skill updates * fix(aws-agents): require shim manifests and prefer v1 payment status
* feat(aws-agents): update skills to reflect AgentCore CLI v1 * fix(aws-agents): fix runtime and harness configuration guidance * fix(aws-agents): correct header allowlist example * fix(aws-agents): ensure agent deployment workflows persist selected target * fix(aws-agents): fix Privy guidance in payments skill * fix(aws-agents): persist selected target on gateway and policy operations * fix(aws-agents): fix payment admin setup instructions * fix(aws-agents): update agent auth and cross-session memory examples * fix: address review findings for agentcore CLI v1 skill updates * fix(aws-agents): require shim manifests and prefer v1 payment status
* feat(aws-agents): update skills to reflect AgentCore CLI v1 * fix(aws-agents): fix runtime and harness configuration guidance * fix(aws-agents): correct header allowlist example * fix(aws-agents): ensure agent deployment workflows persist selected target * fix(aws-agents): fix Privy guidance in payments skill * fix(aws-agents): persist selected target on gateway and policy operations * fix(aws-agents): fix payment admin setup instructions * fix(aws-agents): update agent auth and cross-session memory examples * fix: address review findings for agentcore CLI v1 skill updates * fix(aws-agents): require shim manifests and prefer v1 payment status
Description
Updates AgentCore skills for AgentCore CLI v1.0.0, complementing the skills covered by PR #502. The changes in this PR replace v0 commands and project shapes, correct v1 workflow guidance, and fix issues found during multiple review rounds.
Skills and files covered
Version policy: Updated skills require CLI v1.0.0 or later and use the v1 project format ("version": 2). For v0 projects, they direct users to review an
agentcore migrateplan before applying itType of Change
Checklist
python3 tools/validate.pyBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.